Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added global action colors #779

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Sep 4, 2023

Resolves #778

⚠️⚠️ BREAKING:
border-action-default changed from blue-900 to blue-700
What used border-action-default should instead use border-action-dark and border-action-dark-hover. (input-fields)

React: Use the new global action colors for action colors that should not be changed based on brand

@mrosvik mrosvik marked this pull request as ready for review September 4, 2023 06:02
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be ok code tokens wise 👍

@mimarz mimarz merged commit 2046352 into main Sep 7, 2023
2 checks passed
@mimarz mimarz deleted the tokens/global-action-colors branch September 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens: Action colors should exist as default colors, not only as brand primary and secondary
2 participants